Hi Thierry,
On 05/22/2015 01:02 PM, Thierry Reding wrote:
* PGP Signed by an unknown key
On Thu, May 21, 2015 at 06:44:08PM +0300, Mikko Perttunen wrote:
On 05/21/2015 06:10 PM, Arto Merilainen wrote:
...
+
+ vic->rst = devm_reset_control_get(dev, "vic03");
I might prefer just "vic" as the clock/reset name. The name is often
used as a sort of "role" for the clock/reset for the device, not
necessarily the raw name of the "correct" clock/reset.
I considered that - but I then noticed that
drivers/clk/tegra/clk-tegra124.c was already using vic03 variant. I can
write a patch for changing that too.
Well, the two can be different; the clock-name in device tree kind of means
"string that i use to refer to a clock that powers the VIC unit". It's not
really a big deal though, both ways are used in DT bindings.
I'll insist on calling this vic in the clock-names property. The 03 is
as far as I can tell an encoding of the version number, so if you want
to call this vic04 in some future version we'll have to needlessly
patch the driver.
I agree, this is better without 03 postfix will fix this in the next
version.
- Arto
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
