On 5/18/2015 7:03 AM, Bill Huang wrote:
> This fixes bug in tegra_clk_register_pllss() which mistakenly assume the
> iddq register is the PLL base address.
>
> Signed-off-by: Bill Huang <bilhuang@xxxxxxxxxx>
> ---
> drivers/clk/tegra/clk-pll.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c
> index 05c6d08..f225325 100644
> --- a/drivers/clk/tegra/clk-pll.c
> +++ b/drivers/clk/tegra/clk-pll.c
> @@ -1826,7 +1826,7 @@ struct clk *tegra_clk_register_pllss(const char *name, const char *parent_name,
> struct clk *clk, *parent;
> struct tegra_clk_pll_freq_table cfg;
> unsigned long parent_rate;
> - u32 val;
> + u32 val, val_iddq;
> int i;
>
> if (!pll_params->div_nmp)
> @@ -1874,14 +1874,17 @@ struct clk *tegra_clk_register_pllss(const char *name, const char *parent_name,
> pll_writel(PLLSS_CTRL1_DEFAULT, pll_params->ext_misc_reg[2], pll);
>
> val = pll_readl_base(pll);
> + val_iddq = readl_relaxed(clk_base + pll_params->iddq_reg);
You could/should likely use pll_readl(pll_params->iddq_reg, pll) here.
> if (val & PLL_BASE_ENABLE) {
> - if (val & BIT(pll_params->iddq_bit_idx)) {
> + if (val_iddq & BIT(pll_params->iddq_bit_idx)) {
> WARN(1, "%s is on but IDDQ set\n", name);
> kfree(pll);
> return ERR_PTR(-EINVAL);
> }
> - } else
> - val |= BIT(pll_params->iddq_bit_idx);
> + } else {
> + val_iddq |= BIT(pll_params->iddq_bit_idx);
> + writel_relaxed(val_iddq, clk_base + pll_params->iddq_reg);
likewise you can use pll_writel(val_iddq, pll_params->iddq_reg, pll) here.
-rhyland
--
nvpublic
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
