On Tue, May 19, 2015 at 02:21:01PM +0200, Tomeu Vizoso wrote: > On 18 May 2015 at 17:35, Thierry Reding <thierry.reding@xxxxxxxxx> wrote: > > From: Thierry Reding <treding@xxxxxxxxxx> > > > > In order to ease testing, expose the list of supported EMC frequencies > > via debugfs. > > Looks good to me, but if this is for automated testing, why not just > read the timings from the DT? We would be covering more code that way. > > Reviewed-by: Tomeu Vizoso <tomeu.vizoso@xxxxxxxxxxxxx> The idea is that by putting this into debugfs we have a single source of information to use in tests. Now if in addition to merely testing the frequencies you want to make sure the driver has a consistent representation of what's in device tree we could always write another test that reads the device tree nodes and compares them to the list of supported rates from debugfs. Thierry
Attachment:
pgpYHStW7tlnv.pgp
Description: PGP signature
