On Mon, May 4, 2015 at 9:37 AM, Rhyland Klein <rklein@xxxxxxxxxx> wrote: > From: Bill Huang <bilhuang@xxxxxxxxxx> > > If a PLL has a reset_reg specified, properly handle that in the > enable/disable logic paths. > > Signed-off-by: Bill Huang <bilhuang@xxxxxxxxxx> Minor nit to add kerneldoc for params. Otherwise, LGTM. Reviewed-by: Benson Leung <bleung@xxxxxxxxxxxx> > diff --git a/drivers/clk/tegra/clk.h b/drivers/clk/tegra/clk.h > index b63ef31a2d7a..0146c91df635 100644 > --- a/drivers/clk/tegra/clk.h > +++ b/drivers/clk/tegra/clk.h > @@ -217,6 +217,8 @@ struct tegra_clk_pll_params { > u32 lock_enable_bit_idx; > u32 iddq_reg; > u32 iddq_bit_idx; > + u32 reset_reg; > + u32 reset_bit_idx; Kerneldoc for these two. > u32 sdm_din_reg; > u32 sdm_din_mask; > u32 sdm_ctrl_reg; -- Benson Leung Software Engineer, Chrom* OS bleung@xxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html