On Wed, 2015-03-11 at 11:34 +0100, Tomeu Vizoso wrote:
> --- a/drivers/memory/tegra/Kconfig
> +++ b/drivers/memory/tegra/Kconfig
> +
> +
(Nit: just one empty line, please.)
> +config TEGRA124_EMC
> + bool "Tegra124 External Memory Controller driver"
This patch adds a bool symbol...
> + default y
> + depends on TEGRA_MC && ARCH_TEGRA_124_SOC
> + help
> + This driver is for the External Memory Controller (EMC) found on
> + Tegra124 chips. The EMC controls the external DRAM on the board.
> + This driver is required to change memory timings / clock rate for
> + external memory.
> \ No newline at end of file
(Another nit, reported by git.)
> --- a/drivers/memory/tegra/Makefile
> +++ b/drivers/memory/tegra/Makefile
> @@ -5,3 +5,5 @@ tegra-mc-$(CONFIG_ARCH_TEGRA_114_SOC) += tegra114.o
> tegra-mc-$(CONFIG_ARCH_TEGRA_124_SOC) += tegra124.o
>
> obj-$(CONFIG_TEGRA_MC) += tegra-mc.o
> +
> +obj-$(CONFIG_TEGRA124_EMC) += tegra124-emc.o
... and tegra124-emc.o will never be part of a module ...
> --- /dev/null
> +++ b/drivers/memory/tegra/tegra124-emc.c
... so:
> +#include <linux/module.h>
- I guess linux/module.h is not needed;
> +MODULE_DEVICE_TABLE(of, tegra_emc_of_match);
- this macro will be preprocessed away;
> +static int tegra_emc_probe(struct platform_device *pdev)
> +{
> + [...]
> +
> + platform_set_drvdata(pdev, tegra);
> +
> +
(Nit: this adds two empty lines.)
> + return 0;
> +};
> +MODULE_AUTHOR("Mikko Perttunen <mperttunen@xxxxxxxxxx>");
> +MODULE_DESCRIPTION("Tegra124 EMC memory driver");
> +MODULE_LICENSE("GPL v2");
- and these three macros will be, effectively, preprocessed away,
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
