Re: [PATCH] soc/tegra: pmc: Add Tegra132 support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 9 Jan 2015, Thierry Reding wrote:

> On Thu, Jan 08, 2015 at 10:34:35PM +0000, Paul Walmsley wrote:
> > On Thu, 8 Jan 2015, Thierry Reding wrote:
> > 
> > > From: Thierry Reding <treding@xxxxxxxxxx>
> > > 
> > > Tegra132 uses the same GPU as Tegra124 and the same special-case is
> > > needed to remove clamps. However Tegra132 has a separate chip ID, so in
> > > order to avoid having to extend the list of chip IDs for the special
> > > case, add a feature flag to the SoC data.
> > > 
> > > Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>
> > 
> > Reviewed-by: Paul Walmsley <pwalmsley@xxxxxxxxxx>
> > 
> > Nit: not sure I would call it a special-case; to me it's more of an 
> > evolutionary change due to the radically different GPU in T124 & T132.
> 
> I reworded the commit message slightly, so it says:
> 
> 	Tegra132 uses the same GPU as Tegra124 and therefore requires the same
> 	method to remove clamps. ...
> 
> I hope that's less misleading.

Looks good to me,


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux