Re: [cbootimage PATCH] cbootimage: Add 'b' (binary) flag when using fopen to open a binary file.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/14/2014 09:59 AM, Scott Duplichan wrote:
Add 'b' (binary) flag when using fopen to open a binary file.
This keeps Windows from expanding \n to \r\n and interpreting
<ctrl>z as end of file. The change is to support a Windows
hosted coreboot build environment.

This seems fine; I'll apply it in just a second.

It seems worth being explicit on all fopens re: b-vs-t. To that end, perhaps you could update the following too?

./src/cbootimage.c:161:	context->config_file = fopen(argv[optind++], "r");
./src/cbootimage.c:218:	context.raw_file = fopen(context.output_image_filename, "w+");
./src/data_layout.c:1049:	fp = fopen(context->input_image_filename, "r");

--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux