On Mon, Dec 1, 2014 at 8:01 PM, Thierry Reding <thierry.reding@xxxxxxxxx> wrote: > I think the subject doesn't need "for module use" because that's > implicit in exporting a symbol. > > On Fri, Nov 28, 2014 at 07:12:58PM +0800, Vince Hsu wrote: >> Some Tegra drivers might be complied as kernel modules, and > > "compiled" > >> they need the fuse information for initialization. One >> example is the GK20A Nouveau driver. It needs the GPU speedo >> value to calculate frequency-voltage table. So export >> the tegra_sku_info. > > Also please wrap the commit message at around 72 characters. If you make > the lines too short it becomes almost as difficult to readable as if > they're too long. > > Other than these small nitpicks this looks like a reasonable change to > me. > >> >> Signed-off-by: Vince Hsu <vinceh@xxxxxxxxxx> >> --- >> >> v2: add more description why we need this patch >> >> drivers/soc/tegra/fuse/fuse-tegra.c | 1 + >> 1 file changed, 1 insertion(+) > > Ben, patch 3/3 has a dependency on this one. Would you prefer to merge > this as part of the Nouveau tree or do you want me to provide a stable > branch that you can pull in to resolve the dependency? I'll take the patch, seems the simplest option :) Thanks, Ben. > > In case of the former: > > Acked-by: Thierry Reding <treding@xxxxxxxxxx> > > _______________________________________________ > Nouveau mailing list > Nouveau@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/nouveau > -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
