On Wed, Nov 12, 2014 at 11:14:40AM -0700, Stephen Warren wrote: > On 11/12/2014 05:20 AM, Thierry Reding wrote: > >On Tue, Nov 11, 2014 at 12:49:30PM -0800, Olof Johansson wrote: > >>There are general changes pending to make the /aliases/serial* entries > >>number the serial ports on the system. On tegra, so far the ports have been > >>just numbered dynamically as they are configured so that makes them change. > >> > >>To avoid this, add specific aliases per board to keep the old numbers. This > >>allows us to change the numbering by default on future SoCs while keeping the > >>numbering on existing boards. > ... > >I have applied this to the for-3.19/dt branch. So for anything that is > >post Tegra124 the new rule shall be to add aliases to the SoC .dtsi and > >then use consistent numbering of UART ports across boards? > > > >The alternative is to remain consistent with what this patch does, which > >would be to make the serial port numbering a property of the board. That > >doesn't sound too bad to me either since it'll hide all the unused ports > >on a given board. > > For new SoCs, I think board-specific aliases would make most sense. That > would be consistent with this patch. The only question I had was for > existing SoCs, should we make the switch this patch does, or leave the > aliases inactive there? New SoCs should use more sensible aliases. I can't think of a way to keep backwards compatibility. I mean once a patch is merged to apply aliases as specified in the DTB it'll change behaviour on older DTBs. The best we could achieve is to update DTBs with a flag to say that the aliases are to be ignored. But given that no such flag exists in old DTBs, ABI would still be broken. So I think it's fair to say that aliases have been buggy up to now and therefore relying on deterministic serial port naming is broken, too. Also there's precedent for this kind of thing. Ethernet device names have undergone similar changes and I think people have dealt with it just fine. Also since the aliases haven't been used up to now it isn't really the DT breaking ABI, but rather the kernel, and this patch actually fixes things up. I think the lesson to be learned from this is that it is a mistake to add DT content that isn't used. That said, I guess there is one way to preserve the existing naming after all. The driver could be patched to special-case Tegra20 through Tegra124 and ignore aliases there. But I suspect that there are other SoCs that have the same issue, so this is likely going to be a rather big table. Thierry
Attachment:
pgpgLmCb8h3cO.pgp
Description: PGP signature
