On Fri, Nov 07, 2014 at 04:24:19PM +0000, Anatol Pomozov wrote: > Hi > > On Fri, Nov 7, 2014 at 2:40 AM, Mark Rutland <mark.rutland@xxxxxxx> wrote: > > On Fri, Nov 07, 2014 at 04:16:03AM +0000, Stephen Warren wrote: > >> On 11/06/2014 05:25 PM, Anatol Pomozov wrote: > >> > +Stephen > >> > > >> > This patch is for tegra20_timer that uses register_persistent_clock(). > >> > I did not find any way to share the same arch code for arm/arm64. > >> > > >> > Actually this register_persistent_clock() does not look arm specific > >> > at all. Would it be better to move it somewhere outside of arch/? > >> > >> No CC to linux-tegra@ or the other Tegra maintainers? > >> > >> Yes, I think it'd be best not to have arch-specific APIs, or cut/paste > >> the same code into multiple places. > > > > Agreed. This looks in no way architecture specific, and having this in > > common code would be preferable to copying. > > Where the code common for arm and arm64 should go? > drivers/???/arm_timekeeping.c ? I'd argue that this is in no way specific to ARM, and the current weak functions live in kernel/time/timekeeping.c, so this should too. Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
