On Mon, Oct 13, 2014 at 03:20:03PM +0530, Vidya Sagar wrote: > adds support for suspend_noirq and resume_noirq hooks > of PM framework. Enables powergating of PCIe partition during > suspend. > It also separates allocation part from > tegra_pcie_enable_msi() to make a new API tegra_pcie_alloc_msi() > to avoid passing extra param in the original API This sounds like it should be two separate patches (a changelog that says "It also ..." is a good clue). Maybe even three patches -- the additions in tegra_pcie_power_off() look like they are separable from the dev_pm_ops addition, because tegra_pcie_power_off() is already present and used even before you add dev_pm_ops. Generally, my advice is that if you *can* separate it, you should do so. It's very easy to squash things back together, and separating things makes errors more obvious and bisection more useful. > -static int tegra_pcie_enable(struct tegra_pcie *pcie) > +static int tegra_pcie_check_ports(struct tegra_pcie *pcie) "check_ports" is a not really a very good function name because it doesn't give any clues about what we're checking or what return value to expect. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
