> > What I'm more concerned about is the semantics of the property. What > do the generic code paths gain by standardizing this property? Is it > expected that We really need to come up with a standard property for this and document it rather than continuing to add individual device specific properties each time a driver adds poweroff capability, all doing the same thing (a lot of regulators driver, mfd drivers, soc specific drivers, power drivers already do that, that's very redudant) . This is a simple unification logic. About its name, I found my inspiration with "wakeup-source" which marks an device as able to wakeup the system, poweroff capability is exactly the same except that the device will control the power of the system, so I choose "poweroff-source". However, suggestions are welcome ;) About of_regulator.c, I agree with Mark. poweroff capability is not really specific to regulators, so it does not make sense to put the helper there, imho. Romain -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html