On Tue, Jul 22, 2014 at 06:30:06PM +0100, Pawel Moll wrote: > On Tue, 2014-07-22 at 18:10 +0100, Greg Kroah-Hartman wrote: > > On Tue, Jul 22, 2014 at 11:02:07AM +0100, Pawel Moll wrote: > > > ... describing the root of the device tree, so one can write > > > a platform driver initializing the platform. > > > > > > All references to platform_bus device have been fixed up, > > > although in most cases they could be simply removed or > > > replaced by NULL (platform devices with no parent are adopted > > > by main platform_bus device automagically). > > > > In looking at this some more, I think all of these should be made NULL, > > why are we exporting this symbol at all? > > I think there are about 3 non-obvious uses of it, which would probably > need looking into. All other ones that simply do of_platform_populate() > or platform_device_register*() with platform_bus as a parent, which has > exactly the same effect as it was NULL. > > I can imagine situations where one would want to walk the device > hierarchy stopping at platform_bus, how I'm not sure how "legitimate" > that would be. Not at all "legitimate", use the functions the kernel provides for you if you really wanted to do that instead of trying to do it yourself. > I'll post v3 with NULLs where I think it is enough so we can see the > other cases. Thanks, that would be great. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
