On 06/27/2014 06:19 AM, Peter De Schrijver wrote: > On Thu, Jun 26, 2014 at 05:52:16PM +0200, Stephen Warren wrote: >> On 06/26/2014 09:48 AM, Peter De Schrijver wrote: >>> When writing a module for testing or debugging purposes, there is no way to >>> get hold of clk handles. This patch solves this by exposing all valid clocks >>> as clkdev's for the virtual device tegra-clk-debug. >> >> This is to support clk_get_sys()? >> > > Yes. > >> I guess this seems fine, so feel free to apply it, but I slightly wonder >> why not just include this change as part of the presumably local and >> never-to-be-upstreamed test/dev module? > > The idea is to allow local debug modules to get hold of the struct clk *. I > don't think that's possible without using clk_get_sys()? Well, for a debug hack you can always just add extra clock entries into some DT node and so avoid clk_get_sys:-) My point wasn't so much about not using clk_get_sys in a debug driver, but more that if this patch is only required to support non-upstreamed debug code, perhaps this patch should stay downstream along with that non-upstreamed debug code. That said, I'm not really objecting to it, just making a minor comment. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
