On 16 June 2014 14:17, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote: > On 16 June 2014 12:46, Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> wrote: >> On Wed, Apr 23, 2014 at 08:08:07PM +0100, Russell King wrote: >>> @@ -1507,25 +1529,7 @@ static void sdhci_do_set_ios(struct sdhci_host *host, struct mmc_ios *ios) >>> host->ops->set_clock(host, host->clock); >>> } >>> >>> - if (host->ops->set_uhs_signaling) >>> - host->ops->set_uhs_signaling(host, ios->timing); >>> - else { >>> - ctrl_2 = sdhci_readw(host, SDHCI_HOST_CONTROL2); >>> - /* Select Bus Speed Mode for host */ >>> - ctrl_2 &= ~SDHCI_CTRL_UHS_MASK; >>> - if ((ios->timing == MMC_TIMING_MMC_HS200) || >>> - (ios->timing == MMC_TIMING_UHS_SDR104)) >>> - ctrl_2 |= SDHCI_CTRL_UHS_SDR104; >>> - else if (ios->timing == MMC_TIMING_UHS_SDR12) >>> - ctrl_2 |= SDHCI_CTRL_UHS_SDR12; >>> - else if (ios->timing == MMC_TIMING_UHS_SDR25) >>> - ctrl_2 |= SDHCI_CTRL_UHS_SDR25; >>> - else if (ios->timing == MMC_TIMING_UHS_SDR50) >>> - ctrl_2 |= SDHCI_CTRL_UHS_SDR50; >>> - else if (ios->timing == MMC_TIMING_UHS_DDR50) >>> - ctrl_2 |= SDHCI_CTRL_UHS_DDR50; >>> - sdhci_writew(host, ctrl_2, SDHCI_HOST_CONTROL2); >>> - } >>> + host->ops->set_uhs_signaling(host, ios->timing); >>> >>> if (!(host->quirks2 & SDHCI_QUIRK2_PRESET_VALUE_BROKEN) && >>> ((ios->timing == MMC_TIMING_UHS_SDR12) || >> >> Whoever decided to poorly pick these patches up against my will has >> slightly messed this patch up - whereas my original patch left the >> code correctly formatted, when whoever applied this patch did so, they >> left an additional blank line in the above. > [snip] > Please, feel free to send a patch to fixup my misstake. I will happily apply it. I had a second look to fix it up myself, but I just can't find that your patch was different than the one I applied (beside the conflict I resolved). If you do find any other issue regarding the patches in this patchset - please let me know and I will try to help. Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html