Re: [PATCH v2 2/4] pinctrl: Add NVIDIA Tegra XUSB pad controller support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 11, 2014 at 01:23:59PM -0700, Andrew Bresticker wrote:
> On Tue, Jun 10, 2014 at 4:11 AM, Thierry Reding <thierry.reding@xxxxxxxxx> wrote:
[...]
> > +static int tegra_xusb_padctl_pinconf_group_set(struct pinctrl_dev *pinctrl,
> > +                                              unsigned int group,
> > +                                              unsigned long *configs,
> > +                                              unsigned int num_configs)
> > +{
> > +       struct tegra_xusb_padctl *padctl = pinctrl_dev_get_drvdata(pinctrl);
> > +       const struct tegra_xusb_padctl_lane *lane;
> > +       enum tegra_xusb_padctl_param param;
> > +       unsigned int i;
> > +       u32 value;
> > +
> > +       lane = &padctl->soc->lanes[group];
> > +
> > +       for (i = 0; i < num_configs; i++) {
> > +               param = TEGRA_XUSB_PADCTL_UNPACK_PARAM(configs[i]);
> > +               value = TEGRA_XUSB_PADCTL_UNPACK_VALUE(configs[i]);
> > +
> > +               switch (param) {
> > +               case TEGRA_XUSB_PADCTL_IDDQ:
> > +                       value = padctl_readl(padctl, lane->offset);
> 
> This overwrites the configuration value - probably want to use a
> separate variable for the register value.

Good catch, thanks.

Thierry

Attachment: pgppsXh2lZru2.pgp
Description: PGP signature


[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux