On Thu, Apr 17, 2014 at 07:25:54PM +0200, Lucas Stach wrote: > Am Donnerstag, den 17.04.2014, 14:02 +0200 schrieb Thierry Reding: > > From: Thierry Reding <treding@xxxxxxxxxx> > > > > The hotplug detect GPIO in the current bindings use "-gpio" as suffix, > > whereas the standard suffix is the plural: "-gpios". This small series > > replaces this in three steps to preserve bisectability: > > > > - Patch 1 adds new nvidia,hpd-gpios properties to existing device tree > > files while marking existing nvidia,hpd-gpio ones as deprecated. > > - Patch 2 makes use of the new property name in the driver and updates > > the device tree bindings. > > - Patch 3 removes the deprecated properties from device tree files. > > > > Since this touches both DRM and Tegra trees, I've prepared a stable > > branch[0] that can be pulled into both trees to make the transition > > easier. > > > What's the real benefit to this series? After all you are breaking > existing devicetrees here, as the driver doesn't continue to recognize > the old name. IMHO adding a missed 's' to the property name isn't enough > reason to do this. The series is explicitly done in a way to ensure that at least in-tree device trees will keep working across the whole series. Obviously if anybody were to use a DTB written according to the deprecated binding that would no longer work. However I'd like to eventually convert the driver to use the new GPIO descriptor helpers because they make it a lot easier to deal with the GPIOs. And with the new gpiod_get() function you loose the ability to specify an exact property name as it appends the -gpios suffix automatically. The idea is to rectify this mistake now that there's still a manageable number of boards in the tree and we have never really supported stable devicetree bindings on Tegra anyway. Or to put it differently, there is not enough functionality on Tegra generally to make it practicable to use it in production. Therefore I think it makes sense to fix these issues while it's still a viable option. Thierry
Attachment:
pgpLXpMLX0Pvm.pgp
Description: PGP signature
