On Wed, Apr 16, 2014 at 9:21 AM, Stephen Warren <swarren@xxxxxxxxxxxxx> wrote: > On 04/15/2014 07:25 PM, Andrew Bresticker wrote: >> The AS3722_GPIO_INV bit will always be blindly overwritten by >> as3722_pinctrl_gpio_set_direction() and will be ignored when >> setting the value of the GPIO in as3722_gpio_set() since the >> enable_gpio_invert flag is never set. This will cause an >> initially inverted GPIO to toggle when requested as an output, >> which could be problematic if, for example, the GPIO controls >> a critical regulator. >> >> Instead of setting up the enable_gpio_invert flag, uust leave >> the invert bit alone and check it before setting the GPIO value. > > Reviewed-by: Stephen Warren <swarren@xxxxxxxxxx> > Tested-by: Stephen Warren <swarren@xxxxxxxxxx> > > (not with a 'scope or anything, but an affected system boots in a stable > fashion with this applied) > > Should this be CC: stable? I think so. Kernels with venice2 support should probably have this. I'll resend and fix the typo in the commit message. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
