Re: [PATCH] regmap: Fix possible sleep-in-atomic in fast io mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 18, 2014 at 12:38:42PM +0100, Takashi Iwai wrote:
> Mark Brown wrote:
> > On Tue, Mar 18, 2014 at 12:20:00PM +0100, Takashi Iwai wrote:

> > > regmap deploys the spinlock for the protection when set up in fast_io
> > > mode.  But some places are still left with possible sleep in the lock,
> > > typically allocating memory with GFP_KERNEL.  This patch fixes these
> > > calls by moving the allocations out of the lock.

> > You should have split these two unrelated changes into two patches.

> You're suggesting to split the patch to fix for regmap_bulk_write()
> and regmap_register_patch()?  I don't mind to split, but basically
> both are the very same bug, and the solution is very same, too.

Yes (especially given that the considerations for patch are a bit
different).

> >  I already have a fix for the cache sync in my tree locally which I will
> > test just a soon as I fix whatever broke the -next build for me.

> I don't know why you're talking about the build fix...

I can't exactly test my code if the underlying kernel won't even
compile.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux