On 02/18/2014 08:11 AM, Russell King wrote: > sdhci-tegra provides a get_ro method, which overrides the checking > of the write protect bit in the PRESENT_STATE register in sdhci.c: > > if (host->flags & SDHCI_DEVICE_DEAD) > is_readonly = 0; > else if (host->ops->get_ro) > is_readonly = host->ops->get_ro(host); > else > is_readonly = !(sdhci_readl(host, SDHCI_PRESENT_STATE) > & SDHCI_WRITE_PROTECT); > > This means it's pointless detecting accesses to this register and > manually setting the SDHCI_WRITE_PROTECT as it has no effect. > > This means that the whole of tegra_sdhci_readl() can be removed and > we can use the builtin sdhci readl functionality here. Acked-by: Stephen Warren <swarren@xxxxxxxxxx> > =-DO NOT APPLY-= Is that just because it's an RFC and you want to make sure it doesn't get accepted early, or are you explicitly trying to stop people applying this, testing it, and giving Tested-by? -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
