On 02/13/2014 04:01 AM, Tomasz Figa wrote: > Hi Alexandre, > > On 07.02.2014 05:35, Alexandre Courbot wrote: >> Some firmwares do not put the CPU into idle mode themselves, but still >> need to be informed that the CPU is about to enter idle mode before this >> happens. Add a prepare_idle() operation to the firmware_ops structure to >> handle such cases. >> >> Signed-off-by: Alexandre Courbot <acourbot@xxxxxxxxxx> >> --- >> arch/arm/include/asm/firmware.h | 4 ++++ >> 1 file changed, 4 insertions(+) > > I wonder if .do_idle() couldn't simply return an appropriate error code > to let the upper layer know that it should proceed with normal CPU idle > activation, while still letting the firmware know that the CPU is going > to idle. That seems to disagree with the naming of the operation, and the semantics I assume it has, though. It seems clearer to add an explicit separate op for this. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
