Re: [PATCH] ARM: tegra: enable I2C MUX PCA954x

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/07/2014 01:53 PM, Bryan Wu wrote:
> Cardhu has a PCA9546 for I2C bus extension, which connects to 3
> cameras. It's required for Tegra V4L2 soc camera driver and camera
> sensor drivers.

>  arch/arm/boot/dts/tegra30-cardhu.dtsi | 8 ++++++++
>  arch/arm/configs/tegra_defconfig      | 1 +

DT and defconfig changes go into separate branches. Could I get this
split into two patches please?

> diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi

> +		/* NXP PCA9546 I2C Mux */

That comment isn't useful, since the compatible value below spells out
what the device is.

> +		pca9546@70 {

DT nodes should be named after the class/type of device, not the
identify. As such, use "i2cmux@70".

--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux