On 01/24/2014 03:41 AM, Thierry Reding wrote: > On Thu, Jan 23, 2014 at 10:10:47PM -0800, Olof Johansson wrote: >> Hmm, DRM build failures? I didn't see this pre-merge so >> something recent has changed. > > Indeed. This is caused by the interaction between two things. The > root proble is that the prototypes for the DRM debugfs helpers are > #ifdef'ed in the header file, but the Tegra DRM using them within > IS_ENABLED() protected blocks of code and therefore expects at > least prototypes to exist. > > This used to work fine because tegra_defconfig enabled DEBUG_FS, > but it seems like that was dropped in > 0d8c67218cef8af259e4d12221434a1d7b0f3bbc (ARM: tegra: > tegra_defconfig updates). I had assumed that it was being dropped > from the defconfig because something else selected it, but that is > apparently not what happened. Sometime after 3.13-rc1 came out, I checked it out and did the following to update tegra_defconfig: make tegra_defconfig; make savedefconfig; \ mv defconfig arch/arm/configs/tegra_defconfig This removed CONFIG_DEBUG_FS=y from tegra_defconfig, because drivers/clk/Kconfig contained: > config COMMON_CLK_DEBUG bool "DebugFS representation of clock > tree" select DEBUG_FS ... and tegra_defconfig contains CONFIG_COMMON_CLK_DEBUG=y. However, sometime during 3.14 development, that Kconfig variable was deleted, and instead drivers/clk/clk.c now builds its debugfs code conditionally upon CONFIG_DEBUG_FS directly. Hence, CONFIG_DEBUG_FS no longer gets selected. I guess the best thing is to rebuild tegra_defconfig to add back CONFIG_DEBUG_FS and remove the non non-existant CONFIG_COMMON_CLK_DEBUG. I'll check for any other unexpected changes relative to 3.13 too. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
