[PATCH] drm/tegra: Fix Kconfig dependencies

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



arm:allmodconfig fails to build with several undefined drm and host1x symbols.

drivers/gpu/drm/tegra/bus.c:52: undefined reference to `drm_dev_alloc'
drivers/gpu/drm/tegra/bus.c:56: undefined reference to `drm_dev_register'
drivers/gpu/drm/tegra/bus.c:67: undefined reference to `drm_dev_free'
drivers/gpu/drm/tegra/bus.c:75: undefined reference to `drm_put_dev'
drivers/gpu/drm/tegra/drm.c:445: undefined reference to `host1x_syncpt_get_base'
drivers/gpu/drm/tegra/drm.c:449: undefined reference to `host1x_syncpt_base_id'

and so on.

This is caused by DRM=m but DRM_TEGRA=y. DRM_TEGRA is bool while DRM is
tristate. DRM_TEGRA can not be set to tristate because it depends on unexported
host1x symbols (and possibly others). Fix by updating DRM_TEGRA dependency.

Also, the DRM_TEGRA help text states that it can be built as module.
Remove that text since it is not (or no longer) correct.

Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
---
 drivers/gpu/drm/tegra/Kconfig |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/tegra/Kconfig b/drivers/gpu/drm/tegra/Kconfig
index 8961ba6..9966547 100644
--- a/drivers/gpu/drm/tegra/Kconfig
+++ b/drivers/gpu/drm/tegra/Kconfig
@@ -1,7 +1,7 @@
 config DRM_TEGRA
 	bool "NVIDIA Tegra DRM"
 	depends on ARCH_TEGRA || ARCH_MULTIPLATFORM
-	depends on DRM
+	depends on DRM=y
 	select TEGRA_HOST1X
 	select DRM_KMS_HELPER
 	select DRM_KMS_FB_HELPER
@@ -11,9 +11,6 @@ config DRM_TEGRA
 	help
 	  Choose this option if you have an NVIDIA Tegra SoC.
 
-	  To compile this driver as a module, choose M here: the module
-	  will be called tegra-drm.
-
 if DRM_TEGRA
 
 config DRM_TEGRA_DEBUG
-- 
1.7.9.7

--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux