On Fri, Dec 6, 2013 at 9:36 PM, Stephen Warren <swarren@xxxxxxxxxxxxx> wrote:
> From: Stephen Warren <swarren@xxxxxxxxxx>
>
> The call to gpiochip_add() is not currently error-checked. Add the
> missing checking.
>
> Signed-off-by: Stephen Warren <swarren@xxxxxxxxxx>
Patch applied and Reviewed-by tags added.
> Perhaps this should be Cc: stable since Greg wants more stable patches,
> but it's not a bug that's likely to be hit...
Nah.
> - gpiochip_add(&tegra_gpio_chip);
> + ret = gpiochip_add(&tegra_gpio_chip);
> + if (ret < 0) {
> + irq_domain_remove(irq_domain);
> + return ret;
> + }
I fear we are missing quite a few irq_domain_remove() calls in some
GPIO drivers ... adding to my TODO to do an overview of this.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
