On Wed, Dec 04, 2013 at 10:07:28AM +0000, Lee Jones wrote: > On Wed, 04 Dec 2013, Stefan Agner wrote: > > As I pointed out in the comment above, the struct tps6586x is in the C > > file, so I would need to move that too. That's why I did not made that > > change in the end. What do you think, should I still move (and move the > > struct too?) > Why would the struct have to be moved if the function is inline? If the function is in the header and trying to use a struct that's only defined in the C file then it's not going to build - keeping the struct in the C file only does seem like a worthwhile thing for encapsulation.
Attachment:
signature.asc
Description: Digital signature
