On Tue, Dec 03, 2013 at 01:17:20PM -0700, Stephen Warren wrote: > On 12/02/2013 06:28 AM, Thierry Reding wrote: > > Introduce device tree bindings for the MIPI pad calibration controller > > found on Tegra SoCs. The controller can be used to perform calibration > > of pads used for DSI and CSI peripherals. > > > diff --git a/Documentation/devicetree/bindings/misc/nvidia,tegra114-mipi.txt b/Documentation/devicetree/bindings/misc/nvidia,tegra114-mipi.txt > > > +Required properties: > > +- compatible: "nvidia,tegra<chip>-mipi" > > +- reg: Physical base address and length of the controller's registers. > > +- clocks: The clock consumed by the controller. > > I'd prefer all our new drivers just use clock-names from the start, so > we never have to specify that certain clocks must be at a certain index > in the clocks property. How about: > > + - clocks: Must contain an entry for each entry in clock-names. > + See ../clocks/clock-bindings.txt for details. > + - clock-names: Must include the following entries: > + - mipi > > (or "cal" or whatever makes sense there) "mipi-cal" sounds like a good name. That's also what the clock is called in the TRM. I'll repost with this fixed up and I'll move this file into the mipi subdirectory that I need for the MIPI DSI DT bindings anyway. Thierry
Attachment:
pgpaeij7MU6F2.pgp
Description: PGP signature
