Re: [PATCH V2] ASoC: tegra: use reset framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 26, 2013 at 01:12:47PM -0700, Stephen Warren wrote:
[...]
> +		rst = reset_control_get(&pdev->dev,
> +					configlink_mods[i].rst_name);
> +		if (IS_ERR(rst)) {
> +			dev_err(&pdev->dev, "Can't get reset %s\n",
> +				configlink_mods[i].rst_name);
> +			ret = PTR_ERR(rst);
>  			goto err;

In case where this fails, there's no way to re-assert the resets that
have already been deasserted. That's not an issue introduced by this
patch, though, and perhaps something we may not want to care about at
all, so:

Reviewed-by: Thierry Reding <treding@xxxxxxxxxx>

Attachment: pgpBNEutA4ZZf.pgp
Description: PGP signature


[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux