On Thu, Oct 17, 2013 at 6:25 AM, Stephen Warren <swarren@xxxxxxxxxxxxx> wrote: > On 10/16/2013 09:45 PM, David Cohen wrote: >> Hi Stephen, >> >> On 10/16/2013 12:25 PM, Stephen Warren wrote: >>> From: Stephen Warren <swarren@xxxxxxxxxx> >>> >>> Whenever an IRQ is claimed or freed, call gpio_lock_as_irq() or >>> gpio_unlock_as_irq() on the associated GPIO, to prevent that GPIO from >>> being configured in a manner incompatible with an interrupt. > >> As a suggestion, you could add a pointer to dev on tegra gpio priv data >> and recover it using ira_data_get_irq_chip_data(), instead of using >> static file-scope variable. > > That's true, but I figured it wasn't worth doing that without getting > rid of all the other global data, which is a subject for another patch. Yeah that would be nice, singletons are a bit unorthodox these days but it's certain a separate refactoring. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
