On 10/09/2013 02:23 AM, Joseph Lo wrote: > On Wed, 2013-10-09 at 11:11 +0800, Joseph Lo wrote: >> On Wed, 2013-10-09 at 01:00 +0800, Stephen Warren wrote: >>> On 10/08/2013 02:23 AM, Joseph Lo wrote: >>>> diff --git a/arch/arm/mach-tegra/reset-handler.S b/arch/arm/mach-tegra/reset-handler.S >>> >>>> not_ca9: >>>> + mov32 r9, 0xc0f >>>> + cmp r8, r9 >>>> + bleq tegra_init_l2_for_a15 >>> >>> That's checking whether the CPU type is a Cortex-A15, isn't it? The only >>> CPUs that exist NVIDIA SoCs are Cortex-A9 and Cortex-A15, so I don't see >>> why we need to check whether the CPU is a Cortex-A15, given this label >>> is jumped to only when the CPU isn't a Cortex-A9. >> >> Good catch. Will fix. >> > Ah! I just realize the Cortex-A9 will go through here as well. So I > still need to code to make sure only Cortex-A15 execute the function. In that case, there's a bug in the label name; A9 CPUs shouldn't execute code that's "not_ca9"... -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
