On 09/24/2013 02:20 AM, Peter De Schrijver wrote: > On Mon, Sep 23, 2013 at 08:31:43PM +0200, Stephen Warren wrote: >> On 09/18/2013 08:41 AM, Peter De Schrijver wrote: >>> Introduce a new file for peripheral clocks common between several Tegra >>> SoCs and move Tegra114 to this new infrastructure. Also PLLP and the PLLP_OUT >>> clocks will be initialized here. >> >>> diff --git a/drivers/clk/tegra/clk-tegra-periph.c b/drivers/clk/tegra/clk-tegra-periph.c >> >> Similarly here: don't the following differences exist between the SoCs: >> >> * At least the set of extant peripheral clocks, and perhaps some >> parameters of those clocks. > > That's what the tegra_clks is for. If the clock isn't in that table, it won't > be registered. > >> * The set of legal parents for some peripheral clocks (?) > > If they differ for Tegra20 and Tegra30, we will need some extra clocks here, > which will have a new ID and then only be defined in the tegra_clks for those > SoCs. Alternatively they can stay in the SoC specific files. I guess that would work. However, I'd suggest simply leaving all the SoC-specific stuff in the SoC-specific files until it actually becomes shared. Otherwise, you're simply putting all the code into one big file, and parameterizing it to get the correct SoC-specific clocks registered, when you could just keep the SoC-specific code in the SoC-specific file/functions, and not need any of the conditions. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
