On 09/18/2013 08:40 AM, Peter De Schrijver wrote: > Many clocks are common between several Tegra SoCs. Define an enum to list > them so we can move them to separate files which can be shared between > SoCs. Each SoC specific file will provide an array with the common clocks > which are present on the SoC and their DT binding ID. So, this enum is purely something internal to the driver, and is in no way related to the DT binding clock IDs, nor the HW peripheral clock register bits, and finally is a union of all extant clocks across all chips? If so, I suppose it's OK to make an enum for this. If not, the same comments I had re: trying to unify the DT binding clock IDs would apply here; if there's no architectural guarantee that the clock IDs will be kept the same across all future chips, assuming they are the same seems dangerous... -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html