On 09/06/2013 02:53 AM, Linus Walleij wrote: > On Thu, Sep 5, 2013 at 9:43 PM, Stephen Warren <swarren@xxxxxxxxxxxxx> wrote: ... >> Note that the UID value appears to be incorrect on anything other than >> Tegra20; I'll file an internal bug to track that down. > > Hm, that will not affect the kernel entropy pool so much, but > the crypto driver is in trouble since that seems to be the only > entropy it's using :-( Well, it calls getnstimeofday() too, so there's presumably a small amount of entropy there, unless tegra_aes_rng_reset() gets called at predictable times, which is probably true. > If it will return something like a constant, that is actually a quite > valid case for initializing tmp[1] from the kernel entropy pool > with get_random_bytes() instead of using UID. > > I don't know if the Tegra AES needs that specific initializer > though (it seems not). Shall I propose a patch? That sounds reasonable. Perhaps Varun can comment? -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
