On Wed, Sep 04, 2013 at 12:39:59PM -0600, Stephen Warren wrote:
> On 08/28/2013 09:48 AM, Mikko Perttunen wrote:
> > Add Tegra114 TMDS configuration, add new peak_current field and
> > use new place for drive current override bit on Tegra114 platform.
>
> > diff --git a/drivers/gpu/host1x/dev.c b/drivers/gpu/host1x/dev.c
>
> > static struct of_device_id host1x_of_match[] = {
> > + { .compatible = "nvidia,tegra114-host1x", .data = &host1x01_info, },
>
> We should add that value to the host1x DT binding documentation.
That should be superseeded by a patch from my Tegra114 DSI series. Note
that Tegra114 also uses a slightly updated version of host1x.
> > diff --git a/drivers/gpu/host1x/drm/hdmi.c b/drivers/gpu/host1x/drm/hdmi.c
>
> > static const struct tegra_hdmi_audio_config *
> > tegra_hdmi_get_audio_config(unsigned int audio_freq, unsigned int pclk)
> > {
> > @@ -593,8 +673,20 @@ static void tegra_hdmi_setup_tmds(struct tegra_hdmi *hdmi,
> > tegra_hdmi_writel(hdmi, tmds->pll1, HDMI_NV_PDISP_SOR_PLL1);
> > tegra_hdmi_writel(hdmi, tmds->pe_current, HDMI_NV_PDISP_PE_CURRENT);
> >
> > - value = tmds->drive_current | DRIVE_CURRENT_FUSE_OVERRIDE;
> > - tegra_hdmi_writel(hdmi, value, HDMI_NV_PDISP_SOR_LANE_DRIVE_CURRENT);
> > + if (of_device_is_compatible(hdmi->dev->of_node,
> > + "nvidia,tegra114-hdmi")) {
>
> We shouldn't do this at run-time. Rather, set tegra_hdmi_of_match[]'s
> .data field to a structure that represents the various features of the
> HW, and then make this code conditional upon a feature flag in that
> structure.
I'll take a look at how this could be done. There are a few other places
where we do this check at runtime, so that should be converted at the
same time.
Thierry
Attachment:
pgpQTeEFJu5mx.pgp
Description: PGP signature
