On Tue, Aug 27, 2013 at 11:15:12AM +0200, Chris Desjardins wrote: > Thierry, I have looked at the comments, and I have also talked to SECO, and > they aren't willing to give me the docs necessary to really do the job > correctly (even if they did give me the docs, I am not 100% sure I would be > able to do it correctly without a direct line to their hardware engineers), > they also are unwilling to do it themselves. They did say that they will > give me feedback on a dts file, but the feedback I got from them on the > original one was little more than: this doesn't appear to be correct. To be > honest, we have decided to go with another platform with better support in > the mainline kernel (4th gen x86, because it is powerful, low power, and > well supported), and as a result my seco board is collecting dust. I'm sorry to hear that. > For reference here is the full "technical" feedback I got from seco: > > we noticed some inconsistencies on dts file you provided: with respect to > pcie-controller, ldo2 usage is not correct and PCIe lanes declaration > doesn't look coeherent with actual hardware. > > Not really enough for me to make changes with confidence... I think I have > already mentioned this, but just to be sure, comparing and contrasting the > regulator/pci settings from kernel they provide (pre-device tree) and the > mainline is like comparing apples and oranges. Most of the names have > changed, and even in the few cases where names seem to correlate it would > still take me a huge amount of time to really figure out what I am looking > at in their source/sysfs/etc and translate it to .dts from with > confidence... and I really have no idea how I would verify it (other than > looking at sysfs or something, but to me, looking at what sysfs says about > regulator configuration and verifying that a regulator is configured > correctly are two different things). Indeed. It takes quite a bit of effort to successfully correlate the two datasets. > Thanks for following up on this, sorry I won't be able to help, feel free > to take my .dts file and run with it if you want, or pressure seco into > updating it correctly if you can. I doubt that I'll be able to exert any more pressure than you did. Given my lack of hardware I won't be able to drive that effort myself, but perhaps someone else will pick it up. Thanks for investigating! Thierry > On 27 August 2013 09:56, Thierry Reding <thierry.reding@xxxxxxxxx> wrote: > > > On Sun, Jun 23, 2013 at 03:38:05PM +0200, Chris Desjardins wrote: > > > > > > Signed-off-by: Chris Desjardins <chris.desjardins@xxxxxxxxxxx> > > > --- > > > arch/arm/boot/dts/tegra30-carma.dts | 461 > > +++++++++++++++++++++++++++++++++++ > > > 1 file changed, 461 insertions(+) > > > create mode 100644 arch/arm/boot/dts/tegra30-carma.dts > > > > Hi Chris, > > > > The new PCIe driver is going to be merged in 3.12, so it would be nice > > to see this patch merged as well as given that it is one of the few > > users of PCIe. > > > > Have you had a chance to look at the comments you received? > > > > Thierry > >
Attachment:
pgpmzr4WaQUUg.pgp
Description: PGP signature
