> On 08/08/2013 04:42 PM, Guenter Roeck wrote:
> > On 08/07/2013 11:56 PM, Wei Ni wrote:
> >> The device lm90 can be controlled by the vdd rail.
> >> Adding the power control support to power on/off the vdd rail.
> >> And make sure that power is enabled before accessing the device.
> >>
> >> Signed-off-by: Wei Ni <wni@xxxxxxxxxx>
> >> ---
> >> drivers/hwmon/lm90.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
[...]
> > I consider the messages unnecessary and confusing. You are polluting the log
> > of pretty much every PC user who has one of the supported chips in the system,
> > and of everyone else not using regulators for this chip.
>
> Ok, I will remove these codes.
> So I will write something like:
> if (!IS_ERR(data->lm90_reg)) {
> ret = regulator_enable(data->lm90_reg);
> if (ret < 0) {
> dev_err();
> return ret;
> }
> } else {
> if (PTR_ERR(data->lm90_reg) == -EPROBE_DEFER)
> return -EPRPBE_DEFER;
>
> data->lm90_reg = !!IS_ERR(data->lm90_reg);
No. You do not need this line.
Just use in remove():
if (!IS_ERR(data->lm90_reg))
regulator_disable(data->lm90_reg);
---
��.n��������+%������w��{.n�����{��נ���^n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�
