On Tue, 2013-08-06 at 01:53 +0800, Stephen Warren wrote: > On 08/05/2013 05:21 AM, Joseph Lo wrote: > > The LP1 suspend mode will power off the CPU, clock gated the PLLs and put > > SDRAM to self-refresh mode. Any interrupt can wake up device from LP1. The > > sequence when LP1 suspending: > > > V2: > ... > > * modify tegra30_sdram_pad_save as suggestion > > You should describe the change you made, not why you made the change. > Not everyone reading this new patch version will know/remember what > suggestions were made in response to v1, and that description above > therefore doesn't mean anything to them. Indeed, will improve it next time. > > diff --git a/arch/arm/mach-tegra/sleep-tegra30.S b/arch/arm/mach-tegra/sleep-tegra30.S > > > +/* > > + * tegra30_lp1_reset > > + * > > + * reset vector for LP1 restore; copied into IRAM during suspend. > > + * Brings the system back up to a safe staring point (SDRAM out of > > + * self-refresh, PLLC, PLLM and PLLP reenabled, CPU running on PLLX, > > + * system clock running on the same PLL that it suspended at), and > > + * jumps to tegra_resume to restore virtual addressing. > > + * The physical address of tegra_resume expected to be stored in > > + * PMC_SCRATCH41. > > + * > > + * NOTE: THIS *MUST* BE RELOCATED TO TEGRA_IRAM_CODE_AREA AND MUST BE FIRST. > > This comment still contains the confusing "AND MUST BE FIRST" that was > in v1:-( Oops, I only fixed it in 6/8. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
