On Wed, Jul 31, 2013 at 12:49:05AM +0800, Stephen Warren wrote: > On 07/29/2013 08:54 PM, Richard Zhao wrote: > > On Sat, Jul 27, 2013 at 03:21:20AM +0800, Stephen Warren wrote: > >> (Stripping the Cc list a lot, but adding in the DT binding maintainers) > >> > >> On 07/23/2013 10:09 PM, Richard Zhao wrote: > >>> All Tegra device drivers will soon move to generic DMA device tree bindings. > >>> Add the required properties to the Tegra DT files to support that. The legacy > >>> property nvidia,dma-request-selector will be removed after all drivers have > >>> been converted, in order to maintain bisectability. > >>> > >>> Changes: > >>> - Add '#dma-cells' for apbdma nodes > >>> - And properties 'dmas' and 'dma-names' for apbdma client nodes > >>> - update apbdma DT binding doc > >>> > >>> Signed-off-by: Richard Zhao <rizhao@xxxxxxxxxx> > >>> --- > >>> .../devicetree/bindings/dma/tegra20-apbdma.txt | 1 + > >>> arch/arm/boot/dts/tegra114.dtsi | 27 ++++++++++++++++++++++ > >>> arch/arm/boot/dts/tegra20.dtsi | 27 ++++++++++++++++++++++ > >>> arch/arm/boot/dts/tegra30.dtsi | 25 ++++++++++++++++++++ > >> > >> This patch should be split differently. > >> > >> Patch 1 in the series should include the binding document change and the > >> associated DMA driver change, which will support both the old and new > >> bindings. Binding doc is used to define the way dts describe hw. I still think it is better to squash into this patch. But it's not such a big deal. I'll move it to dma patch since you like it. Thanks Richard > >> > >> Patch 2 should contain the *.dtsi changes. > > > > The reason I update apbdma binding doc here is to make it consistent > > with the mass properties added in dtsi files. > > apbdma has less places of changes than dtsi files. > > It'll still be consistent if you update the binding documentation first, > then update the *.dtsi to conform to the new binding docs. It won't > affect the number of changes. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html