Stephen Warren <swarren@xxxxxxxxxxxxx> wrote @ Thu, 18 Jul 2013 22:28:42 +0200:
> On 07/05/2013 04:44 AM, Hiroshi Doyu wrote:
> > This provides the info about which H/W Accelerators are supported on
> > Tegra SoC. This info is passed from DT. This is necessary to have the
> > unified SMMU driver among Tegra SoCs. Instead of using platform data,
> > DT passes "nvidia,swgroup" now. DT is mandatory in Tegra.
>
> > diff --git a/Documentation/devicetree/bindings/iommu/nvidia,tegra30-smmu.txt b/Documentation/devicetree/bindings/iommu/nvidia,tegra30-smmu.txt
>
> > +- nvidia,swgroups: A bitmap of supported HardWare Accelerators(HWA).
> > + Each bit represents one swgroup. The assignments may be found in header
> > + file <dt-bindings/memory/tegra-swgroup.h>.
>
> There needs to be a default for this field if one is not specified so
> that existing DTs continue to work without modification.
Only enabling PPCS(AHB) can be an option because PPCS has SD/MMC where
rootfs can be located ususally.
> How many cells big is this property?
64
> Is this really a bitmap of HWAs? Surely it's a bitmap of SMMU client
> IDs?
At least this info can be used for PMC too.
.....
> > diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c
>
> > @@ -265,7 +265,7 @@ struct smmu_client {
> > struct device *dev;
> > struct list_head list;
> > struct smmu_as *as;
> > - u32 hwgrp;
> > + u64 hwgrp;
>
> Why is that "hwgrp" not "swgrp"? Don't they represent the same
> thing?
They are same but initial SMMU driver used the term "hwgroup". Should
this be renamed with another patch or can it be left as it is?
....
> > static int __smmu_client_set_hwgrp(struct smmu_client *c,
> > - unsigned long map, int on)
> > + u64 map, int on)
> > {
> > int i;
> > struct smmu_as *as = c->as;
> > @@ -398,12 +400,11 @@ static int __smmu_client_set_hwgrp(struct smmu_client *c,
> > if (!on)
> > map = smmu_client_hwgrp(c);
> >
> > - for_each_set_bit(i, &map, HWGRP_COUNT) {
> > + for_each_set_bit(i, (unsigned long *)&map,
> > + sizeof(map) * BITS_PER_BYTE) {
>
> Why change the type if it just forces you to add this cast?
u32 map; -> u64 map;
for_each_set_bit() expects "unsigned long *" for any length of bitmap.
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
