Re: [PATCH] spi/tegra114: Factor runtime PM out into transfer prepare/unprepare

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Saturday 27 July 2013 04:53 PM, Mark Brown wrote:
From: Mark Brown <broonie@xxxxxxxxxx>

Currently the tegra114 driver acquires a runtime PM reference for the
duration of each transfer. This may result in the IP being powered down
between transfers which would be at best wasteful. Instead it is better
to do this in the callbacks that are generated before and after starting
a series of transfers, keeping the IP powered throughout.

Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>
---

Acked-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>

The reason I kept this in transfer_one() is because prepare/unprepare was getting called in atomic context. But after the change,
Author: Bryan Freed <bfreed@xxxxxxxxxxxx>
Date:   Wed Mar 13 11:17:40 2013 -0700

    spi: Unlock a spinlock before calling into the controller driver.


It is fine to have prepare as blocking call.

--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux