(Stripping CC list a bit) On 07/23/2013 10:09 PM, Richard Zhao wrote: > - driver: remove use of nvidia,dma-request-selector > use dma_request_slave_channel to request channel > - if dmas/dma-names are missing, it still supports cpu based transfer > - update binding doc and specify dmas/dma-names properties as optional I'll simply repeat the comments I already made downstream: Most commit messages aren't written as bullet points. This might be better written as: ---------- Convert the Tegra114 SPI driver to support the standard DMA device-tree bindings. Note that DMA mode is optional; if the DT properties required to support DMA are missing, then the driver will fall back to pure CPU operation. ---------- > diff --git a/Documentation/devicetree/bindings/spi/nvidia,tegra114-spi.txt b/Documentation/devicetree/bindings/spi/nvidia,tegra114-spi.txt > +Optional properties: > +- dmas : The Tegra DMA controller's phandle and request selector for > + this SPI controller. > +- dma-names : Should be "rx-tx". This should reference dma.txt which defines the DMA DT bindings. How about: ---------- Optional properties: - dmas, dma-names : The DMA channel to use for DMA-mode operation. See dma.txt for the definition of these properties. A single entry named "rx-tx" must be specified. ---------- -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
