On 07/05/2013 04:44 AM, Hiroshi Doyu wrote:
> Register platform_devices to IOMMU dynamically via
> ops->{add,remove}_device().
> diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c
> +/*
> + * ASID[0] for the system default
> + * ASID[1] for PPCS, which has SDMMC
I have no idea what PPCS is. The patch description for 21/22 implies
much more than SDMMC is "in PPCS"...
> + * ASID[2][3].. open for drivers, first come, first served.
> + */
> +enum {
> + SYSTEM_DEFAULT,
> + SYSTEM_PROTECTED,
> +};
Why hard-code this mapping? Can't devices be assigned to ASIDs based on
a DT property? I assume there's nothing in the SMMU HW that requires
specific ASIDs to be used?
I don't see anything in this series which implements the "open for
drivers" part of the description for ASID 2/3/...
Perhaps not so relevant here since this patch only uses SYSTEM_DEFAULT
as the ASID number, but don't you need to validate that smmu->num_as is
large enough to support all values in the enum definition above?
Since this patch doesn't actually use anything other than
SYSTEM_DEFAULT, I wonder if this patch shouldn't be squashed into patch
21/22, where multiple ASIDs are actually used?
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
