On 07/17/2013 03:03 PM, Wei Ni wrote: > On 07/16/2013 12:57 AM, Jean Delvare wrote: >> Hi Wei, Guenter, >> >>> + >>> + if ((status & 0x7f) == 0 && (status2 & 0xfe) == 0) >>> + return false; >> >> It's a bit disappointing to not use the freshly introduced constants. >> That being said I agree it would make the code hard to read, so you can >> leave it as is. > > Sorry, I forgot it. > How about to define: > #define LM90_STATUS_MASK 0x7f > #define MAX6696_STATUS2 0xfe Sorry, it should be "#define MAX6696_STATUS2_MASK 0xfe". > > Or since Guenter is for vacation, I can just leave it as is, and wait > him back to talk about below issue. > >> > -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
