On 07/05/2013 04:44 AM, Hiroshi Doyu wrote: > Add "nvidia,memory-client" to identify which swgroup ID a device > belongs to. This property also isn't in the documentation. Again, if client devices are required to have this new property, the DT isn't backwards-compatible; fail:-( > diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi > + nvidia,memory-client = <TEGRA_SWGROUP_HC>; What if there's more than one SMMU in the system, e.g. since there are multiple different master-capable buses? Including the SMMU phandle in the property seems like a good idea so that the SMMU driver knows which devices are affected by it (although a bus structure with affected devices under the SMMU represented as nodes under the SMMU DT node seems a slightly more direct way of representing that, although that solution does only support systems where bus-master transactions flow up the bus structure in the same way that CPU transactions flow down it). What about: nvidia,smmu = <&smmu TEGRA_SWGROUP_HC>; ? > @@ -69,6 +75,8 @@ > reg = <0x54180000 0x00040000>; > clocks = <&tegra_car 24 &tegra_car 98>; > clock-names = "3d", "3d2"; > + nvidia,memory-client = <TEGRA_SWGROUP_NV > + TEGRA_SWGROUP_NV2>; Oh, if there can be more than one, I suggest adding "s" to the end of the property name. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
