On 07/05/2013 04:44 AM, Hiroshi Doyu wrote:
> To prevent of_platform_populate() from trying to populate duplicate
> devices if a device has been already populated.
You need to send drivers/of patches to the DT maintainer and
devicetree-discuss mailing list.
> Signed-off-by: Hiroshi Doyu <hdoyu@xxxxxxxxxx>
> ---
> Need to take care of early_platform_devices, or alternative solution.
I assume that's a TODO item... Are you planning on fleshing out this
patch to address that issue?
> diff --git a/drivers/of/base.c b/drivers/of/base.c
> +struct device *of_get_device(const struct device_node *node)
> +{
> + struct device *dev;
> + unsigned long flags;
> +
> + raw_spin_lock_irqsave(&devtree_lock, flags);
> + dev = node->dev;
> + raw_spin_unlock_irqrestore(&devtree_lock, flags);
The read (and write in of_set_device()) aren't atomic already? I guess
perhaps they aren't necessarily. It sure seems like some higher-level
locking is needed in of_platform_create_pdata() though, since there's
quite a window there between the get() and set() calls. Or, is there
already some locking in place above that, in which case, I 'm not sure
why there's a need for this level of locking here...
> diff --git a/drivers/of/platform.c b/drivers/of/platform.c
> + tmp = of_get_device(np);
> + if (tmp) {
> + dev_info(tmp, "Already populated\n");
> + return to_platform_device(tmp);
> + }
Did you check all callers of this function to make sure that they also
don't do any kind of double-processing?
> diff --git a/include/linux/of.h b/include/linux/of.h
> @@ -60,6 +60,9 @@ struct device_node {
> struct kref kref;
> unsigned long _flags;
> void *data;
> +
> + struct device *dev; /* Set only after populated */
> +
> #if defined(CONFIG_SPARC)
Are the extra blank lines needed?
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
