On 07/08/2013 07:38 AM, Laxman Dewangan wrote:
> Make the entry of Dalmore Power Management Unit device TPS65913
> in dalmore DTS file. The Palma driver support this device.
>
> Enable following submodule of the TPS65913:
> - GPIO driver
> - RTC driver.
> - Power regulator driver.
> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
> + palmas: tps65913@58 {
I assume there's only one TPS65913 in the system, so that node name
doesn't need to contain the unit address to make it unique; the node can
simply be named "tps65913".
> + palmas_gpio: palmas_gpio {
> + palmas_rtc {
> + palmas_pmic {
I don't think those node names need "palmas" in them; they can simply be
"gpio", "rtc", "pmic".
> + ldousb-in-supply = <&tps65090_dcdc1_reg>;
> + regulators {
You'd usually leave a blank line between properties and nodes.
> + vdd_cam_1v8_reg: regulator@6 {
...
> + gpio = <&palmas_gpio 6 0>; /* Palmas GPIO6 */
That comment probably isn't worthwhile; I only insisted on them for
Tegra GPIOs so that the GPIO name could be included somewhere, whereas
for devices with just a small handful of GPIOs without any other names,
there's no point putting a comment, since it's obvious from the cell
content.
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
