On 07/06/2013 01:38 AM, Stephen Warren wrote: > On 07/04/2013 03:09 AM, Wei Ni wrote: >> Enable thermal sensor lm90 for t30 cardhu. > >> diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi > >> + nct1008: nct1008 { >> + compatible = "lm90,nct1008"; > > "lm90" isn't a valid vendor prefix. I believe the value you want is > "onnn,nct1008". Same comment for patch 2/2. > The lm90 doesn't support device tree very well. In the DT, we need to named as "lm90" so that the lm90 driver can be loaded, and we also need to add "nct1008" to indicate this is the nct1008 device, so that the lm90 driver can be loaded with the right i2c_device_id->driver_data. I set the " compatible = "lm90,nct1008" ", this is the simplest way, and we doesn't need to change the lm90.c. Thanks. Wei. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html