[Re: [PATCH 07/32] arm: delete __cpuinit/__CPUINIT usage from all ARM users] On 02/07/2013 (Tue 09:58) Russell King - ARM Linux wrote: > On Tue, Jul 02, 2013 at 04:52:00PM +0800, Joseph Lo wrote: > > I just tested this series on Tegra platform. It looks broken CPU hotplug > > function for Tegra at least. The CPU can't plug-in after unplugging. And > > the system resume function also not working when "enable_nonboot_cpus". > > > > Both of the issue cause system hang up. Are we missing something for > > __cpuinit removal work? > > Check that any assembly code you're using where the __CPUINIT* marker has > been removed is not preceded by an __INIT or similar. This code needs > to end up in the normal .text, .data or .bss sections now. Yes, As Russell says it is entirely possible that the earlier section was __INIT and there was already a missing __FINIT (or .previous). Hence what was __cpuinit got grandfathered into __INIT instead of .text/.data/.bss I'm offline at the moment but will double check myself later this evening if nothing obvious has been found by then. Thanks, Paul. -- -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
