On Thu, 2013-06-27 at 03:40 +0800, Stephen Warren wrote: > On 06/25/2013 03:27 AM, Joseph Lo wrote: > > The Tegra114 can support suspend function now, removing the limitation. > > OK, so this is the first point at which system suspend is enabled on > Tegra114. However, some of the changes in earlier patches sounded like > the might affect, or be required by, cpuidle too. Is that the case? If > so, can you assure me that bisectability of Tegra114 cpuidle is > maintained across this whole series? I think you mean one of the patches I changed the init sequence of CPU idle driver and hook the "tegra_tear_down_cpu" in tegra_init_suspend (under pm.c). I did that was for fixing the dependence of CPU idle and suspend driver. Because we upstreamed the CPU idle "powered-down" support first then system suspend. So we hook the "tegra_tear_down_cpu" in CPU idle driver. But it would cause the system suspend function fail when disabling CPU_IDLE. After reorganizing the sequence, the system suspend is still working after disabling CPU_IDLE. If the PM is disabled, the CPU idle driver still supports at least WFI state. So this series is OK with cpuidle driver. I had tested the previous series (already merged in the branch for 3.11) is ok for Tegra20/30 as well. Thanks for take care. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html