Re: [PATCH] tegrarcm: Add version command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 17, 2013 at 08:58:57PM -0700, Stephen Warren wrote:
> On 06/17/2013 09:24 PM, Allen Martin wrote:
> > Add command line option "--version" that prints the version number and
> > exits.
> 
> Acked-by: Stephen Warren <swarren@xxxxxxxxxx>
> 
> I assume you'll apply all these.

yes

> 
> Although...
> 
> > +static void print_version(char *progname)
> > +{
> > +	fprintf(stderr, "%s %s\n", PACKAGE_NAME, PACKAGE_VERSION);
> > +}
> 
> I wonder if that shouldn't print to stdout; it's the requested output of
> the command, not some error message.

Sounds reasonable.

-Allen
-- 
nvpublic
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux